Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-infra): do not run the lock-closed GitHub action on forks #36000

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 10, 2020

Previously, the lock-closed GitHub action, which runs daily and locks closed inactive issues, was run on each fork of the angular/angular repo. While the action is a no-op on forks, it make still fail from time to time, generating a confusing notification e-mail for the fork owner.

This commit configures the lock-closed action to only run on the main angular/angular repository (using the method suggested here).

Previously, the `lock-closed` GitHub action, which runs daily and locks
closed inactive issues, was run on each fork of the `angular/angular`
repo. While the action is a [no-op on forks][1], it make still fail from
time to time, generating a confusing notification e-mail for the fork
owner.

This commit configures the `lock-closed` action to only run on the main
`angular/angular` repository (using the method suggested [here][2]).

[1]: https://github.com/angular/dev-infra/blob/13b25d383/github-actions/lock-closed/src/main.ts#L117
[2]: https://github.community/t5/GitHub-Actions/Do-not-run-cron-workflows-in-forks/td-p/46756
@gkalpak gkalpak added area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release type: bug/fix labels Mar 10, 2020
@ngbot ngbot bot modified the milestone: needsTriage Mar 10, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@josephperrott josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 10, 2020
@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2020
@matsko matsko closed this in b99b80c Mar 11, 2020
matsko pushed a commit that referenced this pull request Mar 11, 2020
…36000)

Previously, the `lock-closed` GitHub action, which runs daily and locks
closed inactive issues, was run on each fork of the `angular/angular`
repo. While the action is a [no-op on forks][1], it make still fail from
time to time, generating a confusing notification e-mail for the fork
owner.

This commit configures the `lock-closed` action to only run on the main
`angular/angular` repository (using the method suggested [here][2]).

[1]: https://github.com/angular/dev-infra/blob/13b25d383/github-actions/lock-closed/src/main.ts#L117
[2]: https://github.community/t5/GitHub-Actions/Do-not-run-cron-workflows-in-forks/td-p/46756

PR Close #36000
@gkalpak gkalpak deleted the fix-dev-infra-no-action-on-forks branch March 11, 2020 19:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants